Skip to content

apt::source: configure repo only for current architecture #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

bastelfreak
Copy link
Collaborator

@bastelfreak bastelfreak commented Dec 20, 2022

Without this setting, we tell apt to download release information for all architectures apt knows. This includes i386 on amd64 systems. postgresql doesn't publish i386 packages. because of that, it results in a warning during apt update:

N: Skipping acquire of configured file 'main/binary-i386/Packages' as repository 'https://apt.postgresql.org/pub/repos/apt jammy-pgdg InRelease' doesn't support architecture 'i386'

This is fixed with this change.

@bastelfreak bastelfreak requested a review from a team as a code owner December 20, 2022 10:01
@bastelfreak bastelfreak self-assigned this Dec 20, 2022
kenyon
kenyon previously approved these changes Dec 20, 2022
@kenyon
Copy link
Contributor

kenyon commented Dec 20, 2022

Commit message says nginx, but I think you mean postgresql here.

location => $_baseurl,
release => "${facts['os']['distro']['codename']}-pgdg",
repos => 'main',
architecture => $facts['os']['architecture'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum. Real world example of a similar issue, just s/PostgreSQL/Apache/: If on an amd64 system you are using PostgreSQL with a proprietary lib which is only available for i386, you would add i386 architecture to your system (dpkg --add-architecture i386), install postgresql in its i386 flavor and be happy.

Not sure Puppet can handle installing from a specific arch that being said, but this seems perfectly valid.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this architecture mix is ugly :( and the upstream postgres repo doesnt even have i386 anymore.

@bastelfreak
Copy link
Collaborator Author

@kenyon ah right. I fixed it in our nginx module and copied the text. fixed it.

@kenyon
Copy link
Contributor

kenyon commented Dec 20, 2022

@bastelfreak and PR title :) (apt::source was from nginx)

@bastelfreak
Copy link
Collaborator Author

@kenyon apt::source is the defined resource that's changed.

Without this setting, we tell apt to download release information for
all architectures apt knows. This includes i386 on amd64 systems.
postgresql doesn't publish i386 packages. because of that, it results
in a warning during apt update:

N: Skipping acquire of configured file 'main/binary-i386/Packages' as
repository 'https://apt.postgresql.org/pub/repos/apt jammy-pgdg
InRelease' doesn't support architecture 'i386'

This is fixed with this change.
@chelnak chelnak merged commit 3d92e72 into puppetlabs:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants